Correctly transform control file version number in sql entity graph #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh!!! Good catch! |
Hoverbear
approved these changes
Jan 28, 2022
JamesGuthrie
force-pushed
the
jg/fix-version-sql-tree
branch
from
a48b2e8 to
624a1b3
Compare
Commit f00c335 added the ability to use '@CARGO_VERSION@' as a placeholder for 'default_version' in the extension's .control file. That change missed the fact that the contents of the .control file are loaded into the root node of the sql entity graph. This means that when using the placeholder, the default_version in the sql entity graph's control file is '@CARGO_VERSION@'. This change compiles the package version into the sql-generator, which performs the replacement at runtime.
JamesGuthrie
force-pushed
the
jg/fix-version-sql-tree
branch
from
624a1b3 to
52b80ab
Compare
|
@Hoverbear as discussed on Discord, I've updated this PR to compile the |
|
Thanks for this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f00c335 added the ability to use '@CARGO_VERSION@' as a
placeholder for 'default_version' in the extension's .control file.
That change missed the fact that the contents of the .control file are
loaded into the root node of the sql entity graph. This means that when
using the placeholder, the default_version in the sql entity graph's
control file is '@CARGO_VERSION@'.
This change replaces the placeholder with the package version when
executing the compiled sql-generator.